Skip to content

Feature: Feature mesh deformation#2196

Open
Lena-Richter wants to merge 27 commits intomainfrom
feature-mesh_deformation
Open

Feature: Feature mesh deformation#2196
Lena-Richter wants to merge 27 commits intomainfrom
feature-mesh_deformation

Conversation

@Lena-Richter
Copy link
Copy Markdown
Collaborator

@Lena-Richter Lena-Richter commented Mar 2, 2026

Closes #2197

Describe your changes here:
Added mesh deformation support using the new t8_cmesh_mesh_deformation files. This allows moving mesh vertices to new positions defined by a CAD geometry.
The calculation is currently done by focusing on surface vertices and comparing their current locations with the target CAD shape. The displacement for internal vertices is not yet included. A new example, t8_cmesh_mesh_deformation_example.cxx, was added to show how the deformation works.

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation. Make sure to add a file documentation for each file!
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@Lena-Richter Lena-Richter changed the title Feature mesh deformation Feature: Feature mesh deformation Mar 8, 2026
@Lena-Richter Lena-Richter marked this pull request as ready for review March 8, 2026 20:18
@Lena-Richter Lena-Richter marked this pull request as draft March 9, 2026 18:19
@Lena-Richter Lena-Richter marked this pull request as ready for review March 10, 2026 20:00
@Lena-Richter Lena-Richter marked this pull request as draft March 10, 2026 21:06
@Lena-Richter Lena-Richter marked this pull request as ready for review March 12, 2026 19:58
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.42%. Comparing base (3f9df7f) to head (c2175b3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2196   +/-   ##
=======================================
  Coverage   79.42%   79.42%           
=======================================
  Files         115      115           
  Lines       19285    19285           
=======================================
  Hits        15318    15318           
  Misses       3967     3967           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread example/cmesh/t8_cmesh_mesh_deformation_example.cxx Outdated
Comment thread example/cmesh/t8_cmesh_mesh_deformation.cxx
Comment thread example/cmesh/t8_cmesh_mesh_deformation_example.cxx Outdated
Comment thread example/cmesh/t8_cmesh_mesh_deformation_example.cxx
Comment thread example/cmesh/t8_cmesh_mesh_deformation.cxx
Comment thread src/t8_geometry/t8_geometry_implementations/t8_geometry_cad.hxx Outdated
Comment thread src/t8_geometry/t8_geometry_handler.hxx
Comment thread src/CMakeLists.txt Outdated
Comment thread tutorials/features/t8_features_curved_meshes.cxx Outdated
Comment thread tutorials/features/t8_features_curved_meshes.cxx Outdated
@sandro-elsweijer sandro-elsweijer removed their assignment Mar 17, 2026
Comment thread example/cmesh/t8_cmesh_mesh_deformation.cxx Outdated
Comment thread example/cmesh/t8_cmesh_mesh_deformation.cxx Outdated
Comment thread example/cmesh/t8_cmesh_mesh_deformation.cxx Outdated
Comment thread example/cmesh/t8_cmesh_mesh_deformation.cxx Outdated
Comment thread example/cmesh/t8_cmesh_mesh_deformation.cxx Outdated
Comment thread example/cmesh/t8_cmesh_mesh_deformation.cxx Outdated
Comment thread src/t8_geometry/t8_geometry_implementations/t8_geometry_cad.hxx
Comment thread src/t8_geometry/t8_geometry_handler.hxx
Comment thread example/cmesh/t8_cmesh_mesh_deformation.cxx Outdated
Comment thread example/cmesh/t8_cmesh_mesh_deformation.cxx Outdated
Comment thread example/cmesh/t8_cmesh_mesh_deformation.cxx Outdated
Comment thread example/cmesh/t8_cmesh_mesh_deformation.cxx Outdated
Comment thread src/t8_cmesh/t8_cmesh_mesh_deformation/t8_cmesh_mesh_deformation.cxx Outdated
Copy link
Copy Markdown
Member

@sandro-elsweijer sandro-elsweijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there!

Comment thread example/cmesh/t8_cmesh_mesh_deformation.cxx Outdated
t8_global_errorf ("ERROR: Invalid mesh dimension: dim=%d. Dimension must be 1, 2 or 3.\n\n", dim);
sc_options_print_usage (t8_get_package_id (), SC_LP_ERROR, opt, NULL);
}
else if (parsed >= 0) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would happen if parsed was -1? The program would terminate and the user has no clue why

Suggested change
else if (parsed >= 0) {
else {

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't addressed

Comment thread example/cmesh/t8_cmesh_mesh_deformation.cxx Outdated
Comment thread example/cmesh/t8_cmesh_mesh_deformation.cxx Outdated
Comment thread src/t8_cmesh/t8_cmesh_mesh_deformation/t8_cmesh_mesh_deformation.cxx Outdated
Comment thread src/t8_cmesh/t8_cmesh_mesh_deformation/t8_cmesh_mesh_deformation.cxx Outdated
Comment thread src/t8_cmesh/t8_cmesh_mesh_deformation/t8_cmesh_mesh_deformation.cxx Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature mesh deformation

2 participants